chore(seer): Use seer quotas endpoints #91937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
roaga
commented
May 20, 2025
Comment on lines
+41
to
+44
| group=group, | ||
| user=request.user, | ||
| force_event_id=force_event_id, | ||
| source=SeerAutomationSource.ISSUE_DETAILS, |
There was a problem hiding this comment.
switching to an enum for cleanliness
Codecov ReportAttention: Patch coverage is
|
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/sentry/seer/issue_summary.py | 80.00% | 3 Missing |
| src/sentry/seer/autofix.py | 83.33% | 1 Missing |
| src/sentry/tasks/autofix.py | 50.00% | 1 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #91937 +/- ##
==========================================
+ Coverage 84.08% 87.87% +3.79%
==========================================
Files 10170 10159 -11
Lines 582941 582614 -327
Branches 22603 22542 -61
==========================================
+ Hits 490140 511977 +21837
+ Misses 92348 70213 -22135
+ Partials 453 424 -29
roaga
commented
May 20, 2025
| @@ -134,5 +140,8 @@ def get(self, request: Request, group: Group) -> Response: | |||
| "orgHasAcknowledged": org_acknowledgement, | |||
| "userHasAcknowledged": user_acknowledgement, | |||
| }, | |||
| "billing": { | |||
| "hasAutofixQuota": has_autofix_quota, | |||
| }, | |||
| } | |||
| ) | |||
There was a problem hiding this comment.
The plan is to return billing and trial information in the setup check so we can display different things on the UI
jennmueng
approved these changes
May 22, 2025
| @@ -808,6 +816,11 @@ def trigger_autofix( | |||
|
|
|||
| group.update(seer_autofix_last_triggered=timezone.now()) | |||
|
|
|||
| # log billing event for seer autofix | |||
| quotas.backend.record_seer_run( | |||
There was a problem hiding this comment.
So, if we set it up like this does it mean that we count a seer run for each time you press start on autofix, including:
- Hit start on a fresh issue without an autofix
- Hit start over then start on an issue with an autofix
- Automation that calls this method
but not if say, you do a rethink from the very beginning of an Autofix?
|
PR reverted: 94d21bb |
getsentry-bot
added a commit
that referenced
this pull request
May 22, 2025
This reverts commit e135c10. Co-authored-by: roaga <47861399+roaga@users.noreply.github.com>
roaga
added a commit
that referenced
this pull request
May 22, 2025
This reverts commit e135c10. Co-authored-by: roaga <47861399+roaga@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records billable Seer events and checks for available budget before running Seer features. Will follow up with trial status + UI work.